Update xterm dependency to @xterm/xterm and adjust imports accordingly #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
reviewed
May 9, 2025
| @@ -39,7 +39,7 @@ | |||
| "tailwind-merge": "^2.2.2", | |||
| "usehooks-ts": "^3.1.0", | |||
| "validator": "^13.12.0", | |||
| "xterm": "^5.3.0", | |||
| "@xterm/xterm": "^5.0.0", | |||
There was a problem hiding this comment.
Hi I'm not sure I tested it with this we can probably use latest although I'm not very familiar with git to update the PR
|
Don't sweat it, I ended up putting in a comprehensive PR to upgrade almost
all the NPM packages today!
Marc Brooks
http://about.me/IDisposable
http://twitter.com/IDisposable
…On Fri, May 9, 2025, 06:46 elibrody ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ui/package.json
<#3 (comment)>:
> @@ -39,7 +39,7 @@
"tailwind-merge": "^2.2.2",
"usehooks-ts": "^3.1.0",
"validator": "^13.12.0",
- "xterm": "^5.3.0",
+ ***@***.***/xterm": "^5.0.0",
Hi I'm not sure I tested it with this we can probably use latest although
I'm not very familiar with git to update the PR
—
Reply to this email directly, view it on GitHub
<#3 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGVMSZGAPXHUPFVGIAIMZL25SIQ5AVCNFSM6AAAAABXCP2PJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMRYGAYDIMJXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be working flawlessly